[
https://issues.apache.org/jira/browse/SOLR-8288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004246#comment-15004246
]
Mark Miller commented on SOLR-8288:
-----------------------------------
bq. This null check is not necessary.
I was originally trying to use leaderCoreNodeName for the identity check, in
which case you do need the null check. I switched to using the core url for the
check, but I have left this null check in - I find it makes it much more
explicit that that variable can be null here, rather than just counting on the
fact that the equals method will handle the null how we want.
bq. Is it worth adding a test where a node tries to put itself into recovery?
If you can add a test for this, it would be nice to have, but I don't see a
good way to do it without some invasive ugly code. It should probably spin out
into it's own JIRA unless something can be done quickly.
> DistributedUpdateProcessor#doFinish should explicitly check and ensure it
> does not try to put itself into LIR.
> --------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-8288
> URL: https://issues.apache.org/jira/browse/SOLR-8288
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Attachments: SOLR-8288.patch
>
>
> We have to be careful about this because currently, something like a commit
> is sent over http even to the local node and if that fails for some reason,
> the leader might try and LIR itself.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
