[ 
https://issues.apache.org/jira/browse/SOLR-6736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004885#comment-15004885
 ] 

Varun Rajput commented on SOLR-6736:
------------------------------------

Thanks [~gchanan] for the detailed review. Please also refer to my previous 
patch 
(https://issues.apache.org/jira/secure/attachment/12768656/SOLR-6736-newapi.patch)
 in which I did go the route of using Overseer but passing the content stream 
in the zookeeper message didn't work out as it got converted into a string. 
Maybe there is a better way of doing that which didn't occur to me. I can take 
your help in going that route or an alternate one.

As for the security, this is implemented using a system property which needs to 
be set before starting up solr, as suggested by a few members in this ticket. 
The flag "isUploadEnabled" checks if uploading configsets is enabled.
{code}
   public ConfigSetsHandler(final CoreContainer coreContainer) {
     this.coreContainer = coreContainer;
+    isUploadEnabled = Boolean.parseBoolean(System.getProperty(
+        ConfigSetParams.ENABLE_CONFIGSET_UPLOAD, 
ConfigSetParams.ENABLE_CONFIGSET_UPLOAD_DEFAULT));
   }
{code}

I will take care of the minor corrections, thanks for pointing them out!

> A collections-like request handler to manage solr configurations on zookeeper
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-6736
>                 URL: https://issues.apache.org/jira/browse/SOLR-6736
>             Project: Solr
>          Issue Type: New Feature
>          Components: SolrCloud
>            Reporter: Varun Rajput
>            Assignee: Anshum Gupta
>         Attachments: SOLR-6736-newapi.patch, SOLR-6736-newapi.patch, 
> SOLR-6736.patch, SOLR-6736.patch, SOLR-6736.patch, SOLR-6736.patch, 
> SOLR-6736.patch, SOLR-6736.patch, SOLR-6736.patch, SOLR-6736.patch, 
> newzkconf.zip, test_private.pem, test_pub.der, zkconfighandler.zip, 
> zkconfighandler.zip
>
>
> Managing Solr configuration files on zookeeper becomes cumbersome while using 
> solr in cloud mode, especially while trying out changes in the 
> configurations. 
> It will be great if there is a request handler that can provide an API to 
> manage the configurations similar to the collections handler that would allow 
> actions like uploading new configurations, linking them to a collection, 
> deleting configurations, etc.
> example : 
> {code}
> #use the following command to upload a new configset called mynewconf. This 
> will fail if there is alredy a conf called 'mynewconf'. The file could be a 
> jar , zip or a tar file which contains all the files for the this conf.
> curl -X POST -H 'Content-Type: application/octet-stream' --data-binary 
> @testconf.zip 
> http://localhost:8983/solr/admin/configs/mynewconf?sig=<the-signature>
> {code}
> A GET to http://localhost:8983/solr/admin/configs will give a list of configs 
> available
> A GET to http://localhost:8983/solr/admin/configs/mynewconf would give the 
> list of files in mynewconf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to