[
https://issues.apache.org/jira/browse/SOLR-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010466#comment-15010466
]
Shawn Heisey commented on SOLR-8302:
------------------------------------
Strong +1 for this idea! I haven't reviewed the patch yet.
When I started looking at NIO2 conversion for Solr (in general, not limited to
this class), I noticed a lot of code that concatenates strings of harcoded
filesystem or resource paths with forward slashes. The code would be much
cleaner and cross-platform with resolve and other NIO2 methods.
I personally would be OK with simply changing the API, but the javadoc at the
class level does not actually say that it is expert or internal. I'm guessing
deprecation will be required, unless it's sufficient to add the internal/expert
designation in the javadoc at the same time as this change. I do see one
method currently marked as expert, but I don't think that method is affected by
this patch.
> SolrResourceLoader should take a Path to its instance directory, rather than
> a String
> -------------------------------------------------------------------------------------
>
> Key: SOLR-8302
> URL: https://issues.apache.org/jira/browse/SOLR-8302
> Project: Solr
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Attachments: SOLR-8302.patch
>
>
> First step of SOLR-8282. We have a whole bunch of code that deals with
> loading things relative to the resource loader's instance dir. These become
> a lot simpler if the instance dir is a Path.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
