On Wed, Nov 18, 2015 at 4:39 PM, Mike Drob <[email protected]> wrote: > Hi devs, > > While tracing some through some log statements, I noticed that not all of > the classes are using their own loggers. In particular, there are several > instances of using SolrCore.log outside of the SolrCore class. There's also > a few places where we use an inherited logger, like in DirectUpdateHandler2. > > Are these uses intentional? Sometimes they might make the logs more > logically grouped, but they also can make it more difficult to find where > execution was taking place if a non-namesake logger is used. > > If people agree that it's worth correcting, I'm happy to file JIRA(s) and > provide necessary patches.
I think it depends on which ones... It doesn't always make sense to create a new logger just because something was refactored. But sometimes it does. Some of the cases are probably due to laziness (i.e. I didn't want to stop and think about whether a new logger made sense, I just wanted to get on with things ;-) So yes, I'm sure some of them are worth correcting. -Yonik --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
