Github user elyograg commented on the pull request:
https://github.com/apache/lucene-solr/pull/210#issuecomment-158099893
I think you've got the default values backwards, but other than that it
looks good to me. For 5.x, we need the default to be false so existing setups
do not change behavior, but it is sensible to change the default to true with
6.0.
We can use github patches, but cannot use the pull request directly or do
the commit on github. If you can create an issue in Jira, that will be helpful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
