[ https://issues.apache.org/jira/browse/LUCENE-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015494#comment-15015494 ]
Daniel Mitterdorfer commented on LUCENE-6902: --------------------------------------------- Sorry, wasn't aware of that. Thanks for pointing it out. > Fail fsync immediately > ---------------------- > > Key: LUCENE-6902 > URL: https://issues.apache.org/jira/browse/LUCENE-6902 > Project: Lucene - Core > Issue Type: Improvement > Components: core/store > Affects Versions: 5.3.1 > Reporter: Daniel Mitterdorfer > Assignee: Uwe Schindler > Priority: Minor > Fix For: 5.4 > > Attachments: ioutils-fsync-fail-fast.patch > > > While analysing a build issue in Elasticsearch I stumpled upon > org.apache.lucene.util.IOUtils.fsync. It has a retry loop in fsync whenever > an IOException occurs. However, there are lots of instances where a retry is > not useful, e.g. when a channel has been closed, a ClosedChannelException is > thrown and IOUtils#fsync still tries to fsync multiple times on the closed > channel. > After bringing the issue to Robert's attention, he even opted for removing > the retry logic entirely for fsyncing. > Please find attached a patch that removes the retry logic. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org