[ 
https://issues.apache.org/jira/browse/SOLR-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018774#comment-15018774
 ] 

Joel Bernstein commented on SOLR-8306:
--------------------------------------

I've reviewed the patch and I think it looks good. This is going to need tests 
though before it can be committed. It's going to need both single node 
(TestExpandComponent.java) and distributed test cases 
(DistributedExpandComponentTest).

I won't have the time to add these in the near future but I can review tests 
and provide feedback. 

After the tests are added, I'll still need to spend more time with this before 
I commit it, so I don't think it's going to make it into 5.4. But the following 
release is doable.

> Enhance ExpandComponent to allow expand.hits=0
> ----------------------------------------------
>
>                 Key: SOLR-8306
>                 URL: https://issues.apache.org/jira/browse/SOLR-8306
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 5.3.1
>            Reporter: Marshall Sanders
>            Priority: Minor
>              Labels: expand
>             Fix For: 5.3.1
>
>         Attachments: SOLR-8306.patch, SOLR-8306.patch, 
> [email protected]
>
>
> This enhancement allows the ExpandComponent to allow expand.hits=0 for those 
> who don't want an expanded document returned and only want the numFound from 
> the expand section.
> This is useful for "See 54 more like this" use cases, but without the 
> performance hit of gathering an entire expanded document.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to