[
https://issues.apache.org/jira/browse/SOLR-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022246#comment-15022246
]
Ishan Chattopadhyaya commented on SOLR-7169:
--------------------------------------------
Thanks Dominik.
I tried to take a look at your patch. There are lots of whitespace changes. Is
it please possible for you to post another patch that contains just the
required change? It would be easier to review the change that way.
As Upayavira mentioned, an SVN patch is more likely to be reviewed here than a
git patch, but I can volunteer to convert your git patch to an SVN one for now
for ease of reviewing.
> init.d status command has incorrect return value
> ------------------------------------------------
>
> Key: SOLR-7169
> URL: https://issues.apache.org/jira/browse/SOLR-7169
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
> Affects Versions: 5.0
> Environment: Debian stable
> Reporter: Martin Skøtt
> Assignee: Timothy Potter
>
> {{/etc/init.d/solr status}} returns 0 if Solr is not running, but according
> to the LSB 0 means that the service is running
> (http://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html).
> In my situation this causes problems when managing the service with Puppet
> which uses the status command to determine if a service should be started.
> Puppet simply doesn't start the service because it thinks its already
> running. Any other script depending on the result of the status command will
> suffer similar problems.
> Workaround for other Puppet users:
> Setting {{hasstatus => false}} and {{pattern => "solr.solr.home"}} in the
> service definition works for me.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
