[ https://issues.apache.org/jira/browse/LUCENE-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley reassigned LUCENE-6900: ------------------------------------ Assignee: David Smiley > Grouping sortWithinGroup should use Sort.RELEVANCE to indicate that, not null > ----------------------------------------------------------------------------- > > Key: LUCENE-6900 > URL: https://issues.apache.org/jira/browse/LUCENE-6900 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/grouping > Reporter: David Smiley > Assignee: David Smiley > Priority: Minor > Attachments: LUCENE_6900.patch > > > In AbstractSecondPassGroupingCollector, {{withinGroupSort}} uses a value of > null to indicate a relevance sort. I think it's nicer to use Sort.RELEVANCE > for this -- after all it's how the {{groupSort}} variable is handled. This > choice is also seen in GroupingSearch; likely some other collaborators too. > [~martijn.v.groningen] is there some wisdom in the current choice that > escapes me? If not I'll post a patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org