[ 
https://issues.apache.org/jira/browse/SOLR-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030223#comment-15030223
 ] 

Yonik Seeley commented on SOLR-8230:
------------------------------------

I like the getFacetDescription() in FacetRequest, it's nice and general.  
Perhaps we should make a generic base-class implementation of 
FacetRequest.toString() that uses this as well.

In FacetContext, I see you build a tree - having the current context point to 
all it's sub-contexts (even when debug isn't turned on).
That may be problematic memory-wise...  FacetContext contains a reference to 
(among other things) "base", the DocSet for the facet domain.  Previously 
FacetContext objects were not retained longer than needed.

> Create Facet Telemetry for Nested Facet Query
> ---------------------------------------------
>
>                 Key: SOLR-8230
>                 URL: https://issues.apache.org/jira/browse/SOLR-8230
>             Project: Solr
>          Issue Type: Sub-task
>          Components: Facet Module
>            Reporter: Michael Sun
>             Fix For: Trunk
>
>         Attachments: SOLR-8230.patch, SOLR-8230.patch
>
>
> This is the first step for SOLR-8228 Facet Telemetry. It's going to implement 
> the telemetry for a nested facet query and put the information obtained in 
> debug field in response.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to