[
https://issues.apache.org/jira/browse/LUCENE-6912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-6912:
---------------------------------
Attachment: LUCENE_6912.patch
Here's a patch.
The trickiest part was debugging the fact that CachingCollector (in Lucene
core) has a ScoreCachingCollector that did _not_ override needsScores() to be
true; and that tripped test failures in TestGrouping.testRandom(). Boy does
that test method need refactoring, by the way; I'm so glad to be done tracing
through it!
> Grouping's Collectors should have smart needsScores()
> -----------------------------------------------------
>
> Key: LUCENE-6912
> URL: https://issues.apache.org/jira/browse/LUCENE-6912
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/grouping
> Reporter: David Smiley
> Assignee: David Smiley
> Fix For: 5.5
>
> Attachments: LUCENE_6912.patch
>
>
> The Grouping module has numerous Collector implementations, and only a couple
> perhaps override needsScore() with an optimal choice. Lets do this for all
> of them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
