[ 
https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031323#comment-15031323
 ] 

David Smiley commented on LUCENE-5868:
--------------------------------------

(I edited your comment to correct your reference to me, not a similarly named 
person)

I think the surgery makes sense.  It adds a useful feature.  The approach 
leverages the existing underlying BytesRefHash which may not be as optimal as 
some sort of LongHash or similar but whatever -- progress not perfection.  
Should someone care, such improvements could be made later.

I admit I didn't look at the details of your tests; that would take much more 
time. I was mostly curious about the implementation side and of the lambdas you 
made reference to.

> JoinUtil support for NUMERIC docValues fields 
> ----------------------------------------------
>
>                 Key: LUCENE-5868
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5868
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Mikhail Khludnev
>            Assignee: Mikhail Khludnev
>            Priority: Minor
>             Fix For: 5.5
>
>         Attachments: LUCENE-5868-lambdarefactoring.patch, 
> LUCENE-5868-lambdarefactoring.patch, LUCENE-5868.patch, LUCENE-5868.patch, 
> LUCENE-5868.patch, qtj.diff
>
>
> while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at 
> least. 
> I plan to provide test/patch. It might be important, because Solr's join can 
> do that. Please vote if you care! 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to