[
https://issues.apache.org/jira/browse/SOLR-8351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregory Chanan updated SOLR-8351:
---------------------------------
Attachment: SOLR-8351.patch
I added a toString to HdfsLock to match what's in NativeFsLock, since that
seems in spirit with what this patch is doing.
I also removed the change to LockFactory -- it feels weird to clutter a simple
interface declaration with toString implementation details. I'm not against
the log message changing, though. Perhaps the correct place to do that is in a
derivation on the LockFactories/Locks similar to what you are suggesting with
the Directories. That should probably be done in a separate jira though.
Let me know what you think [~mdrob].
> Improve HdfsDirectory toString representation
> ---------------------------------------------
>
> Key: SOLR-8351
> URL: https://issues.apache.org/jira/browse/SOLR-8351
> Project: Solr
> Issue Type: Improvement
> Reporter: Mike Drob
> Assignee: Gregory Chanan
> Fix For: Trunk
>
> Attachments: SOLR-8351.patch, SOLR-8351.patch
>
>
> HdfsDirectory's toString is used in logging by the DeletionPolicy and
> SnapPuller (and probably others). It would be useful to match what
> FSDirectory does, and print the directory it refers to.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
