[
https://issues.apache.org/jira/browse/SOLR-8339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035869#comment-15035869
]
Shalin Shekhar Mangar commented on SOLR-8339:
---------------------------------------------
bq. With this change, can we remove
org.apache.solr.client.solrj.util.ClientUtils#toSolrInputDocument method? And
org.apache.solr.client.solrj.util.ClientUtils#toSolrDocument ?
We can deprecate those in 5.x and remove in trunk.
[~ichattopadhyaya] - SolrDocument used to be serializable but you have removed
that in your patch. Same for SolrInputDocument. That is a compat-break. Can you
put that back?
> SolrDocument and SolrInputDocument should have a common interface
> -----------------------------------------------------------------
>
> Key: SOLR-8339
> URL: https://issues.apache.org/jira/browse/SOLR-8339
> Project: Solr
> Issue Type: Bug
> Reporter: Ishan Chattopadhyaya
> Assignee: Shalin Shekhar Mangar
> Attachments: SOLR-8339.patch, SOLR-8339.patch, SOLR-8339.patch
>
>
> Currently, both share a Map interface (SOLR-928). However, there are many
> common methods like createField(), setField() etc. that should perhaps go
> into an interface/abstract class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
