[
https://issues.apache.org/jira/browse/LUCENE-6916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035919#comment-15035919
]
Robert Muir commented on LUCENE-6916:
-------------------------------------
Well, my issue is that:
* try-with definitely adds complexity, its like try/catch but with more
complexity on top.
* its "optimizing for a failure case"
* it is not an issue for any directories in lucene.
* once its done here, i am worried about a precedent, where every single lucene
test must be in try-with.
> BaseDirectoryTestCase should use try-with-resources for its Directories
> -----------------------------------------------------------------------
>
> Key: LUCENE-6916
> URL: https://issues.apache.org/jira/browse/LUCENE-6916
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: LUCENE-6916.patch
>
>
> I'm playing around with writing a nio2 FileSystem implementation for HDFS
> that will work with Directory, and it currently leaks threads everywhere
> because if a BaseDirectoryTestCase test fails it doesn't close its Directory.
> This obviously won't be a problem if everything passes, but it will probably
> be a while before that's true and it makes iterative development a bit of a
> pain.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
