Christine Poerschke created SOLR-8360:
-----------------------------------------

             Summary: ExternalFileField.getValueSource uses req.datadir but 
this.schema
                 Key: SOLR-8360
                 URL: https://issues.apache.org/jira/browse/SOLR-8360
             Project: Solr
          Issue Type: Task
            Reporter: Christine Poerschke
            Assignee: Christine Poerschke


{{ExternalFileField.getValueSource(SchemaField field, QParser parser)}} has 
available:
* datadir
** parser.getReq().getCore().getDataDir()
** this.schema.getResourceLoader().getDataDir()
* schema
** parser.getReq().getSchema()
** this.schema

{{ExternalFileField.getValueSource}} uses 
{{parser.getReq().getCore().getDataDir()}} explicitly but implicitly 
{{this.schema}} - should it use {{parser.getReq().getSchema()}} instead (Option 
1 patch)? Or if in practice actually req.datadir and this.datadir are always 
the same could we stop using the parser argument (Option 2 patch (1 line))?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to