[ https://issues.apache.org/jira/browse/SOLR-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037376#comment-15037376 ]
Varun Thacker commented on SOLR-8131: ------------------------------------- Hi Erik, bq. ShowFileRequestHandlerTest.java: maybe use the DEFAULT_MANAGED_SCHEMA_RESOURCE_NAME constant instead on "QueryRequest request = new QueryRequest(params("file","managed-schema"));" I didn't make this change. The argument being we should leave hardcoded constants in our tests. That way is someone in the future accidentally changed DEFAULT_MANAGED_SCHEMA_RESOURCE_NAME the tests would atleast catch it as a break. bq. explicitly in all the shipped configs and just leave it out entirely. (for one, no one really needs to change the resource name) Incorporated in the patch > Make ManagedIndexSchemaFactory as the default in Solr > ----------------------------------------------------- > > Key: SOLR-8131 > URL: https://issues.apache.org/jira/browse/SOLR-8131 > Project: Solr > Issue Type: Wish > Components: Data-driven Schema, Schema and Analysis > Reporter: Shalin Shekhar Mangar > Labels: difficulty-easy, impact-high > Fix For: 5.4, Trunk > > Attachments: SOLR-8131.patch, SOLR-8131.patch, SOLR-8131.patch > > > The techproducts and other examples shipped with Solr all use the > ClassicIndexSchemaFactory which disables all Schema APIs which need to modify > schema. It'd be nice to be able to support both read/write schema APIs > without needing to enable data-driven or schema-less mode. > I propose to change all 5.x examples to explicitly use > ManagedIndexSchemaFactory and to enable ManagedIndexSchemaFactory by default > in trunk (6.x). -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org