[ 
https://issues.apache.org/jira/browse/SOLR-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Gerlowski updated SOLR-8266:
----------------------------------
    Attachment: SOLR-8266.patch

Making the first two changes Joel laid out (StreamHandler and ParallelStream) 
seemed easy.

I'm having a little more trouble with the third piece of this patch- tweaking 
StreamingTest's use of parallel streams to use a properly configured 
StreamFactory/StreamContext.

The current patch gets through several of the parallel-stream tests, before 
hitting {{testParallelEOF}} and failing with the follow stack trace:

{code}
java.io.IOException: java.util.concurrent.ExecutionException: 
java.io.IOException: --> https://127.0.0.1:35540/collection1/:Invalid stream 
expression count(merge(search(collection1,q="id:(4 1 8 7 
9)",fl="id,a_s,a_i",sort="a_i 
asc",partitionKeys=a_i,zkHost="127.0.0.1:36053/solr"),search(collection1,q="id:(0
 2 3 6)",fl="id,a_s,a_i",sort="a_i 
asc",partitionKeys=a_i,zkHost="127.0.0.1:36053/solr"),on="a_i asc")) - function 
'count' is unknown (not mapped to a valid TupleStream)
        at 
__randomizedtesting.SeedInfo.seed([19FC8C86B647325A:E5A7AB021C6ECB2F]:0)
        at 
org.apache.solr.client.solrj.io.stream.CloudSolrStream.openStreams(CloudSolrStream.java:353)
        at 
org.apache.solr.client.solrj.io.stream.CloudSolrStream.open(CloudSolrStream.java:234)
        at 
org.apache.solr.client.solrj.io.stream.StreamingTest.getTuples(StreamingTest.java:1821)
        at 
org.apache.solr.client.solrj.io.stream.StreamingTest.testParallelEOF(StreamingTest.java:1697)
        at 
org.apache.solr.client.solrj.io.stream.StreamingTest.streamTests(StreamingTest.java:1795)

{code}

I've still got some investigation to do here; probably just overlooking 
something simple.  But it's late here, and I'd like to upload my progress so I 
can continue from a different computer in the morning.  (And if anyone chimes 
in with thoughts/advice, all the better).

> Remove Java Serialization from the Streaming API
> ------------------------------------------------
>
>                 Key: SOLR-8266
>                 URL: https://issues.apache.org/jira/browse/SOLR-8266
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Joel Bernstein
>         Attachments: SOLR-8266.patch
>
>
> This is being done mainly for security reasons but it's also architecturally 
> the right thing to do.
> Going forward only Streaming Expressions will be used to serialize Streaming 
> API Objects. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to