[ 
https://issues.apache.org/jira/browse/SOLR-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Dyer updated SOLR-4280:
-----------------------------
    Attachment: SOLR-4280.patch

Here is an updated patch for Trunk.  I've included unit tests and changed 
javadoc to reflect the added functionality.  I've also modified how this gets 
triggered.  Rather than introduce a new request parameter, the user passes in 
"spellcheck.maxResultsForSuggest" as a fractional percent, between 0 and 1.  So 
if the user wants no more than 5% of the most-selective filter's results to be 
the maximum results to trigger suggestions, they would specify 
"spellcheck.maxResultsForSuggest=.05".  If, for instance, the most-selective 
filter returns (by itself) 100 documents, then the effective maximum number of 
hits we will return without triggering spelling suggestions is 5.

[~markus17] does this all sound right to you?  Is this still a feature you want 
and would be interested in seeing committed?

> spellcheck.maxResultsForSuggest based on filter query results
> -------------------------------------------------------------
>
>                 Key: SOLR-4280
>                 URL: https://issues.apache.org/jira/browse/SOLR-4280
>             Project: Solr
>          Issue Type: Improvement
>          Components: spellchecker
>            Reporter: Markus Jelsma
>             Fix For: 4.9, Trunk
>
>         Attachments: SOLR-4280-trunk-1.patch, SOLR-4280-trunk.patch, 
> SOLR-4280-trunk.patch, SOLR-4280.patch
>
>
> spellcheck.maxResultsForSuggest takes a fixed number but ideally should be 
> able to take a ratio and calculate that against the maximum number of results 
> the filter queries return.
> At least in our case this would certainly add a lot of value. >99% of our 
> end-users search within one or more filters of which one is always unique. 
> The number of documents for each of those unique filters varies significantly 
> ranging from 300 to 3.000.000 documents in which they search. The 
> maxResultsForSuggest is set to a reasonable low value so it kind of works 
> fine but sometimes leads to undesired suggestions for a large subcorpus that 
> has more misspellings.
> Spun off from SOLR-4278.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to