[
https://issues.apache.org/jira/browse/SOLR-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046806#comment-15046806
]
ASF subversion and git services commented on SOLR-8360:
-------------------------------------------------------
Commit 1718580 from [~cpoerschke] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1718580 ]
SOLR-8360: simplify ExternalFileField.getValueSource implementation (merge in
revision 1718562 from trunk)
> ExternalFileField.getValueSource uses req.datadir but this.schema
> -----------------------------------------------------------------
>
> Key: SOLR-8360
> URL: https://issues.apache.org/jira/browse/SOLR-8360
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Attachments: SOLR-8360-option1.patch, SOLR-8360-option2.patch
>
>
> {{ExternalFileField.getValueSource(SchemaField field, QParser parser)}} has
> available:
> * datadir
> ** parser.getReq().getCore().getDataDir()
> ** this.schema.getResourceLoader().getDataDir()
> * schema
> ** parser.getReq().getSchema()
> ** this.schema
> {{ExternalFileField.getValueSource}} uses
> {{parser.getReq().getCore().getDataDir()}} explicitly but implicitly
> {{this.schema}} - should it use {{parser.getReq().getSchema()}} instead
> (Option 1 patch)? Or if in practice actually req.datadir and this.datadir are
> always the same could we stop using the parser argument (Option 2 patch (1
> line))?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
