[
https://issues.apache.org/jira/browse/SOLR-8367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048782#comment-15048782
]
Mark Miller commented on SOLR-8367:
-----------------------------------
bq. An optimization might be to break out of the whole loop when closed, since
it looks like not much will be happening anyway.
Since they are all fired off async, I don't know that it is really worth it.
All the isClosed stuff is really just best effort to bail early, but not really
critical it's at every point.
> The new LIR 'all replicas participate' failsafe code needs to be improved.
> --------------------------------------------------------------------------
>
> Key: SOLR-8367
> URL: https://issues.apache.org/jira/browse/SOLR-8367
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Attachments: SOLR-8367.patch, SOLR-8367.patch, SOLR-8367.patch
>
>
> For one, it currently only kicks in the first attempted leader. If it's
> another replica that is stuck in LIR, it won't help.
> Second, when we attempt to be leader, knowing we might fail due to LIR, we
> should not put other replicas into recovery if they fail to sync with us -
> not until we know we will actually be leader.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
