[ 
https://issues.apache.org/jira/browse/LUCENE-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002730#comment-13002730
 ] 

Mark Miller commented on LUCENE-2939:
-------------------------------------

{quote}
Worse, this whole situation (people getting angry at the RM for doing
precisely what the RM is supposed to do) is a disincentive for
future RMs to volunteer doing releases, thus causing even less
frequent releases. It's already hard enough for us to get a release
out as it is.{quote}

I'm not sure I agree. Declaring that this will not get in is beyond the scope 
of an RM in my opinion. Putting pressure is fine, but just because being an RM 
is hard is not a King for a day pass IMO. It's up to the RM to build the 
release candidate from whatever issues he wants - does that mean he needs to 
man handle JIRA?


{quote}
The RM is supposed to be an asshole (not that Robert has acted like
one, here, imho).
{quote}

I don't think he is? Too strong a word. I didn't even use it full to refer to 
the 2 actions I was commenting on. First, I said a acting like a bit of an 
asshole and I separated it a distance as theoretical. It was weak sauce 
commentary on the two actions I've pointed out:

1. Just reverting a change another respected committer made immediately and 
without discussion - without too much investigation - because that issue was 
subsumed by another issue that had already been moved for 3.1 consideration and 
we where still discussing.

2. Declaring that this will not make it in over ongoing discussion.

{quote}S/he has full authority to draw the line, crack the
whip, do whatever it takes to get the release out.{quote}

Do whatever it takes? Come on...

bq. We all cannot question that, unless we want to step up and be the RM 
because it is NOT an easy job.

I do question it. I have stepped up to be the RM, I know it's not an easy job, 
and I'll volunteer to do it again sometime.

Robert is great at it - in general he has all my support in the world. I 
certainly understand the difficulties hes facing trying to point this release 
and he has my sympathies - and I wish he had more of my help. But that doesn't 
change my reaction to his actions. I feel the same way and I have the same 
responses to it. Meanwhile, I still like and respect Robert.

> Highlighter should try and use maxDocCharsToAnalyze in 
> WeightedSpanTermExtractor when adding a new field to MemoryIndex as well as 
> when using CachingTokenStream
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2939
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2939
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/highlighter
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 3.1.1, 3.2, 4.0
>
>         Attachments: LUCENE-2939.patch, LUCENE-2939.patch, LUCENE-2939.patch
>
>
> huge documents can be drastically slower than need be because the entire 
> field is added to the memory index
> this cost can be greatly reduced in many cases if we try and respect 
> maxDocCharsToAnalyze
> things can be improved even further by respecting this setting with 
> CachingTokenStream

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to