[
https://issues.apache.org/jira/browse/SOLR-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055442#comment-15055442
]
Varun Thacker commented on SOLR-8120:
-------------------------------------
Hi Cao,
Maybe we can use a try-with-resource statement here ? It would handle the close
itself even if an exception is thrown. Also we should catch the exception and
return false?
> Validate index files on replica before old index is deleted
> -----------------------------------------------------------
>
> Key: SOLR-8120
> URL: https://issues.apache.org/jira/browse/SOLR-8120
> Project: Solr
> Issue Type: Improvement
> Components: replication (java)
> Reporter: Shalin Shekhar Mangar
> Labels: difficulty-easy, impact-high
> Fix For: 5.4, Trunk
>
> Attachments: SOLR-8120.patch
>
>
> During replication, if a full sync is necessary then the detection of
> corruption will happen after the index has been cleaned up (refer to
> solrCore.getDirectoryFactory().remove(indexDir); before calling
> openNewSearcherAndUpdateCommitPoint()) in IndexFetcher.
> SOLR-8119 will make this issue obsolete but until then we should perform
> trivial verification (maybe just open a reader and close?) before the replica
> blows away its old index?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
