[ 
https://issues.apache.org/jira/browse/SOLR-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated SOLR-2405:
-------------------------------

    Attachment: SOLR-2405_browse_should_not_use_facet_date.patch

The attached patch addresses these two issues. It was actually non-trivial to 
switch the /browse interface to not use facet.date... a little refactoring was 
in order.

And I took care to do the +1MILLIS trick for the range boundaries. That's 
another issue that just feels wrong; I had to basically hard-code knowledge in 
generating the UI as to where I needed to adjust for inclusive/exclusive.  It 
would be nice if the facet response included information to generate these 
ranges simpler.

> solrconfig.xml tweaks: add DIH lib & remove facet.date
> ------------------------------------------------------
>
>                 Key: SOLR-2405
>                 URL: https://issues.apache.org/jira/browse/SOLR-2405
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: David Smiley
>             Fix For: 3.1
>
>         Attachments: SOLR-2405_browse_should_not_use_facet_date.patch
>
>
> I reviewed the example solrconfig.xml on branch_3x to see if anything needs 
> addressing prior to release.
> * the <lib/> includes don't bring in the DIH, yet it does for most other 
> contribs.  It strictly isn't necessary, but the DIH is probably the most used 
> contrib and some people will want to add a DIH request-handler declaration 
> and expect it to work. I recall someone failed to do this recently on the 
> user list for 3x. FYI the DIH was once included in the solr war by default 
> but that changed.
> * facet.date is deprecated in favor of facet.range. Consequently the /browse 
> interface should use facet.range instead.
> I could submit a patch but I'd like agreement first so I don't waste my time.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to