[
https://issues.apache.org/jira/browse/SOLR-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060966#comment-15060966
]
Joel Bernstein commented on SOLR-8190:
--------------------------------------
Gave this a quick review. I like the idea of implementing closable, but in this
case close() would get called twice for each test.
Maybe the better approach is to call close() in the finally block of the
methods that call open().
> Implement Closeable on TupleStream
> ----------------------------------
>
> Key: SOLR-8190
> URL: https://issues.apache.org/jira/browse/SOLR-8190
> Project: Solr
> Issue Type: Bug
> Components: SolrJ
> Affects Versions: Trunk
> Reporter: Kevin Risden
> Assignee: Joel Bernstein
> Priority: Minor
> Attachments: SOLR-8190.patch, SOLR-8190.patch
>
>
> Implementing Closeable on TupleStream provides the ability to use
> try-with-resources
> (https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html)
> in tests and in practice. This prevents TupleStreams from being left open
> when there is an error in the tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
