hymm, maybe this is not a great idea...  many things assume the entire
response is represented as a single NamedList.

but I still think we should drop the old format in XMLWriter



On Mon, Mar 7, 2011 at 4:32 PM, Ryan McKinley <[email protected]> wrote:
> Currently we have:
>
>  public NamedList<Object> getResponseHeader() {
>    @SuppressWarnings("unchecked")
>          SimpleOrderedMap<Object> header = (SimpleOrderedMap<Object>)
> values.get("responseHeader");
>          return header;
>  }
>
> and then every response writer pick out this value and treats it different.
>
> Can we just put the variable directly on SolrQueryResponse?
>
> Also, any need for /trunk to keep the old style response header format
> in XMLWriter?
>
>    if (version<=2100 && sz>0) {
>      Object header = lst.getVal(0);
>      if (header instanceof NamedList &&
> "responseHeader".equals(lst.getName(0))) {
>        writer.write("<responseHeader>");
> ...
>
> I'm hoping to clean up the response writers, and the responeHeader
> sticks out as a baby step.
>
> ryan
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to