[ 
https://issues.apache.org/jira/browse/SOLR-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066835#comment-15066835
 ] 

Mark Miller commented on SOLR-8450:
-----------------------------------

Okay, I see. I got the wrong test in my head in the Jetty upgrade issue.

This is the concurrent update solr server, so it's streaming. We count on those 
entities not being retryable and the retry failing.

{quote}
      // if the request is not fully sent, we retry
      // streaming updates are not a problem, because they are not retryable
      httpClient.setHttpRequestRetryHandler(new 
DefaultHttpRequestRetryHandler(){
        @Override
        protected boolean handleAsIdempotent(final HttpRequest request) {
          return false; // we can't tell if a Solr request is idempotent
        }
      });
{quote}

What that means is that we don't explicitly handle reties with streaming, but 
we don't need to because those entities can't be retried anyway.

> Internal HttpClient used in SolrJ is retries requests by default
> ----------------------------------------------------------------
>
>                 Key: SOLR-8450
>                 URL: https://issues.apache.org/jira/browse/SOLR-8450
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java, SolrJ
>            Reporter: Shalin Shekhar Mangar
>             Fix For: 5.5, Trunk
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to