[
https://issues.apache.org/jira/browse/SOLR-8454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anshum Gupta updated SOLR-8454:
-------------------------------
Attachment: SOLR-8454.patch
Updated patch.
I've cleaned up more code in this patch while we are at it. We should however
explicit mention that in the ticket summary that we are not only improving the
logging here but also cleaning up code.
Here are the things that I have changed:
* Removed unused import for ThreadFactory
* Removed the unwanted _path_ param from addSecuritynodeWatcher() method. The
path is always SOLR_SECURITY_CONF_PATH and so it makes sense to just directly
use it.
* In addSecuritynodeWatcher.process() removed the following code as those
conditions are never true. The code block doesn't throw KeeperException or
InterruptedException:
{code}
if (e instanceof KeeperException) throw (KeeperException) e;
if (e instanceof InterruptedException) throw (InterruptedException) e;
{code}
* Capitalized the log line I mentioned in my last comment.
> Improve logging by ZkStateReader
> --------------------------------
>
> Key: SOLR-8454
> URL: https://issues.apache.org/jira/browse/SOLR-8454
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 5.5, Trunk
>
> Attachments: SOLR-8454.patch, SOLR-8454.patch, SOLR-8454.patch,
> SOLR-8454.patch
>
>
> Improve logging output by ZkStateReader, by adding the following:
> * Use LOG.foo() with parameters properly (i.e. not concatenating strings w/ +)
> * Surround parameters with [], to help readability, especially w/ empty values
> * Add missing string messages, where I felt a message will clarify
> * Convert some try-catch to a try-multicatch and improve output log message
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
