[
https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071304#comment-15071304
]
Mark Miller commented on SOLR-8451:
-----------------------------------
It's the right thing to do. I have read the doc, the code, and mailing list
info. I have done tests.
After you are done using a connection you need to do either two things: abort
it or close the content stream. If you abort it, you won't reuse the
connection. There is no need to read through the whole inputstream. There is no
need to use abort in normal safe code unless you need that as a feature to
interrupt a request. All the proper example code shows the pattern to use is to
just close the content input stream.
In the end, it's really simple to test by hand and see what causes connection
reuse and what breaks it.
It was a mistake to add the abort call, but luckily it never had an effect -
closing the content stream ended the request first anyway.
> We should not call method.abort in HttpSolrClient.
> --------------------------------------------------
>
> Key: SOLR-8451
> URL: https://issues.apache.org/jira/browse/SOLR-8451
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Attachments: SOLR-8451.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
