[
https://issues.apache.org/jira/browse/SOLR-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071474#comment-15071474
]
Ishan Chattopadhyaya edited comment on SOLR-8220 at 12/25/15 9:59 AM:
----------------------------------------------------------------------
Updating the patch:
# SolrIndexSearcher's getNonStoredDVs() method now returns unmodifiable sets of
field names
# Added another method in ReturnFields and SolrReturnFields which returns the
additionally requested field names, irrespective of a wantsAll ({{\*}}) being
present in the fl=. This is an overloaded getLuceneFieldNames() with a boolean
parameter to "ignoreWantsAll". Is there something better we can name it to?
# Now fl=*,a3 case also returns a3, irrespective of whether a3 has
useDocValuesAsStored. (This change was made in DocsStreamer's constructor,
under:
{code}
// add non-stored DV fields that may have been requested
if (rctx.getReturnFields().wantsAllFields()) {
{code}
[~shalinmangar] Please feel free to drop changes for points 2, 3, if you think
this doesn't make sense from a usecase point of view.
was (Author: ichattopadhyaya):
Updating the patch:
# SolrIndexSearcher's getNonStoredDVs() method now returns unmodifiable sets of
field names
# Added another method in ReturnFields and SolrReturnFields which returns the
additionally requested field names, irrespective of a wantsAll ({{\*}}) being
present in the fl=.
# Now fl=*,a3 case also returns a3, irrespective of whether a3 has
useDocValuesAsStored. (This change was made in DocsStreamer's constructor,
under:
{code}
// add non-stored DV fields that may have been requested
if (rctx.getReturnFields().wantsAllFields()) {
{code}
> Read field from docValues for non stored fields
> -----------------------------------------------
>
> Key: SOLR-8220
> URL: https://issues.apache.org/jira/browse/SOLR-8220
> Project: Solr
> Issue Type: Improvement
> Reporter: Keith Laban
> Attachments: SOLR-8220-5x.patch, SOLR-8220-ishan.patch,
> SOLR-8220-ishan.patch, SOLR-8220-ishan.patch, SOLR-8220-ishan.patch,
> SOLR-8220.patch, SOLR-8220.patch, SOLR-8220.patch, SOLR-8220.patch,
> SOLR-8220.patch, SOLR-8220.patch, SOLR-8220.patch, SOLR-8220.patch,
> SOLR-8220.patch, SOLR-8220.patch, SOLR-8220.patch, SOLR-8220.patch,
> SOLR-8220.patch, SOLR-8220.patch, SOLR-8220.patch, SOLR-8220.patch,
> SOLR-8220.patch, SOLR-8220.patch, SOLR-8220.patch, SOLR-8220.patch,
> SOLR-8220.patch, SOLR-8220.patch, SOLR-8220.patch, SOLR-8220.patch,
> SOLR-8220.patch
>
>
> Many times a value will be both stored="true" and docValues="true" which
> requires redundant data to be stored on disk. Since reading from docValues is
> both efficient and a common practice (facets, analytics, streaming, etc),
> reading values from docValues when a stored version of the field does not
> exist would be a valuable disk usage optimization.
> The only caveat with this that I can see would be for multiValued fields as
> they would always be returned sorted in the docValues approach. I believe
> this is a fair compromise.
> I've done a rough implementation for this as a field transform, but I think
> it should live closer to where stored fields are loaded in the
> SolrIndexSearcher.
> Two open questions/observations:
> 1) There doesn't seem to be a standard way to read values for docValues,
> facets, analytics, streaming, etc, all seem to be doing their own ways,
> perhaps some of this logic should be centralized.
> 2) What will the API behavior be? (Below is my proposed implementation)
> Parameters for fl:
> - fl="docValueField"
> -- return field from docValue if the field is not stored and in docValues,
> if the field is stored return it from stored fields
> - fl="*"
> -- return only stored fields
> - fl="+"
> -- return stored fields and docValue fields
> 2a - would be easiest implementation and might be sufficient for a first
> pass. 2b - is current behavior
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
