[ 
https://issues.apache.org/jira/browse/SOLR-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073165#comment-15073165
 ] 

Tom Hill commented on SOLR-8420:
--------------------------------

Certainly could be changed. Looks like it currently would overflow if you are 
looking at more than 6 million+ dates, which is a pretty small number today.

Downside is small loss of precision for smaller datasets.

I think it probably should be changed. I'll update the patch.
 

> Date statistics: sumOfSquares overflows long
> --------------------------------------------
>
>                 Key: SOLR-8420
>                 URL: https://issues.apache.org/jira/browse/SOLR-8420
>             Project: Solr
>          Issue Type: Bug
>          Components: SearchComponents - other
>    Affects Versions: 5.4
>            Reporter: Tom Hill
>            Priority: Minor
>         Attachments: 0001-Fix-overflow-in-date-statistics.patch, 
> 0001-Fix-overflow-in-date-statistics.patch, StdDev.java
>
>
> The values for Dates are large enough that squaring them overflows a "long" 
> field. This should be converted to a double. 
> StatsValuesFactory.java, line 755 DateStatsValues#updateTypeSpecificStats Add 
> a cast to double 
> sumOfSquares += ( (double)value * value * count);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to