[
https://issues.apache.org/jira/browse/SOLR-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074750#comment-15074750
]
Varun Thacker commented on SOLR-8461:
-------------------------------------
Hi [~caomanhdat] ,
Patch looks great! Couple of comments -
1. With the patch we check if the replica is active, we should also also check
if the replica's nodeName belongs in the live nodes list. This is required for
a scenario like this - Someone kills the node using "kill -9 <pid>" / OOM crash
. In the cluster state that replica will still show us "active".
HttpSolrCall#getCoreByCollection does the same thing
2. Maybe move the code into a function - say "getActiveReplicasForCollection" ?
The both CloudSolrStream and ParallelSteam can reuse it.
> CloudSolrStream and ParallelStream can choose replicas that are not active
> --------------------------------------------------------------------------
>
> Key: SOLR-8461
> URL: https://issues.apache.org/jira/browse/SOLR-8461
> Project: Solr
> Issue Type: Bug
> Reporter: Joel Bernstein
> Attachments: SOLR-8461.patch, SOLR-8461.patch, SOLR-8461.patch
>
>
> Currently CloudSolrStream and ParallelStream don't check the state of the
> replicas they route requests to. This can result in replicas that are not
> active receiving request.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
