[
https://issues.apache.org/jira/browse/SOLR-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076574#comment-15076574
]
Yonik Seeley edited comment on SOLR-8475 at 1/2/16 5:10 PM:
------------------------------------------------------------
Why was "log" changed to "LOG"? That seems inconsistent with all other
instances in the code base.
bq. New patch with a fix uncovered by one of the tests.
Do you mean you found an existing bug? Or that your first refactor patch
caused a bug?
I assume this patch should be for trunk only?
I notice a lot of changes like this:
{code}
-
+
{code}
It looks like empty lines are being replaced with spaces. That's not
intentional is it?
Some of these changes I don't necessarily find more readable. This for
instance:
{code}
- qc.setQuery(query)
- .setFilterList(filter)
- .setSort(lsort)
- .setOffset(offset)
- .setLen(len)
- .setNeedDocSet(true);
+
qc.setQuery(query).setFilterList(filter).setSort(lsort).setOffset(offset).setLen(len).setNeedDocSet(true);
{code}
was (Author: [email protected]):
Why was "log" changed to "LOG"? That seems inconsistent with all other
instances in the code base.
bq. New patch with a fix uncovered by one of the tests.
Do you mean you found an existing bug? Or that your first refactor patch
caused a bug?
I assume this patch should be for trunk only?
I notice a lot of changes like this:
{code}
-
+
{code}
It looks like empty lines are being replaced with spaces. That's not
intentional is it?
> Some refactoring to SolrIndexSearcher
> -------------------------------------
>
> Key: SOLR-8475
> URL: https://issues.apache.org/jira/browse/SOLR-8475
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 5.5, Trunk
>
> Attachments: SOLR-8475.patch, SOLR-8475.patch, SOLR-8475.patch
>
>
> While reviewing {{SolrIndexSearcher}}, I started to correct a thing here and
> there, and eventually it led to these changes:
> * Moving {{QueryCommand}} and {{QueryResult}} to their own classes.
> * Moving FilterImpl into a private static class (was package-private and
> defined in the same .java file, but separate class).
> * Some code formatting, imports organizing and minor log changes.
> * Removed fieldNames (handled the TODO in the code)
> * Got rid of usage of deprecated classes such as {{LegacyNumericUtils}} and
> {{Legacy-*-Field}}.
> I wish we'd cut down the size of this file much more (it's 2500 lines now),
> but I've decided to stop here so that the patch is manageable. I would like
> to explore further refactorings afterwards, e.g. extracting cache management
> code to an outer class (but keep {{SolrIndexSearcher}}'s API the same, if
> possible).
> If you have additional ideas of more cleanups / simplifications, I'd be glad
> to do them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
