[
https://issues.apache.org/jira/browse/SOLR-8432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15080429#comment-15080429
]
Dennis Gove commented on SOLR-8432:
-----------------------------------
The reason for the single @test calling out to multiple functions has to do
with the test setup code in AbstractFullDistribZkTestBase. Each test method
will go through realitively expensive test setup / teardown. By only having a
single test method with calls out to individual methods we can avoid that
repeated setup/teardown code.
I ran both the original test class and these changes and the runtime difference
is significant. The original version completes in 36s while the separated
versions takes 490s.
I think for this change to be accepted it would have to include changes in the
base classes to move some of the setup work from test method setup to test
class setup. (might actually require new base classes so as not to impact other
tests using these base test classes).
> Split StreamExpressionTest into separate tests
> ----------------------------------------------
>
> Key: SOLR-8432
> URL: https://issues.apache.org/jira/browse/SOLR-8432
> Project: Solr
> Issue Type: Test
> Affects Versions: Trunk
> Reporter: Jason Gerlowski
> Priority: Trivial
> Fix For: Trunk
>
> Attachments: SOLR-8432.patch
>
>
> Currently, {{StreamExpressionTest}} consists of a single JUnit test that
> calls 10 or 15 methods, each targeting a particular type of stream or
> scenario.
> Each of these scenario's would benefit being split into its own separate
> JUnit test. This would allow each scenario to pass/fail independently.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
