[
https://issues.apache.org/jira/browse/SOLR-8489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15084514#comment-15084514
]
Steve Rowe commented on SOLR-8489:
----------------------------------
Compilation on branch_5x is failing while compiling
{{TestMiniSolrCloudCluster.java}}. See e.g.
https://builds.apache.org/job/Lucene-Solr-Maven-5.x/1152/.
{{ant compile-test}} fails for me - {{Map.putIfAbsent()}} was added in Java8:
{noformat}
common.compile-test:
[javac] Compiling 7 source files to
/Users/sarowe/svn/lucene/dev/branches/branch_5x/solr/build/solr-core/classes/test
[javac]
/Users/sarowe/svn/lucene/dev/branches/branch_5x/solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudCluster.java:103:
error: cannot find symbol
[javac] collectionProperties.putIfAbsent(CoreDescriptor.CORE_CONFIG,
"solrconfig-tlog.xml");
[javac] ^
[javac] symbol: method putIfAbsent(String,String)
[javac] location: variable collectionProperties of type Map<String,String>
[javac]
/Users/sarowe/svn/lucene/dev/branches/branch_5x/solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudCluster.java:104:
error: cannot find symbol
[javac] collectionProperties.putIfAbsent("solr.tests.maxBufferedDocs",
"100000");
[javac] ^
[javac] symbol: method putIfAbsent(String,String)
[javac] location: variable collectionProperties of type Map<String,String>
[javac]
/Users/sarowe/svn/lucene/dev/branches/branch_5x/solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudCluster.java:105:
error: cannot find symbol
[javac] collectionProperties.putIfAbsent("solr.tests.ramBufferSizeMB",
"100");
[javac] ^
[javac] symbol: method putIfAbsent(String,String)
[javac] location: variable collectionProperties of type Map<String,String>
[javac]
/Users/sarowe/svn/lucene/dev/branches/branch_5x/solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudCluster.java:107:
error: cannot find symbol
[javac] collectionProperties.putIfAbsent("solr.tests.mergePolicy",
"org.apache.lucene.index.TieredMergePolicy");
[javac] ^
[javac] symbol: method putIfAbsent(String,String)
[javac] location: variable collectionProperties of type Map<String,String>
[javac]
/Users/sarowe/svn/lucene/dev/branches/branch_5x/solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudCluster.java:108:
error: cannot find symbol
[javac] collectionProperties.putIfAbsent("solr.tests.mergeScheduler",
"org.apache.lucene.index.ConcurrentMergeScheduler");
[javac] ^
[javac] symbol: method putIfAbsent(String,String)
[javac] location: variable collectionProperties of type Map<String,String>
[javac]
/Users/sarowe/svn/lucene/dev/branches/branch_5x/solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudCluster.java:109:
error: cannot find symbol
[javac] collectionProperties.putIfAbsent("solr.directoryFactory",
(persistIndex ? "solr.StandardDirectoryFactory" : "solr.RAMDirectoryFactory"));
[javac] ^
[javac] symbol: method putIfAbsent(String,String)
[javac] location: variable collectionProperties of type Map<String,String>
[javac] Note:
/Users/sarowe/svn/lucene/dev/branches/branch_5x/solr/core/src/test/org/apache/solr/search/mlt/CloudMLTQParserTest.java
uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 6 errors
{noformat}
> TestMiniSolrCloudCluster.createCollection to support extra & alternative
> collectionProperties
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-8489
> URL: https://issues.apache.org/jira/browse/SOLR-8489
> Project: Solr
> Issue Type: Test
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Fix For: 5.5, Trunk
>
> Attachments: SOLR-8489.patch
>
>
> * add optional collectionProperties map arg and use putIfAbsent instead of
> put with the map
> * move persistIndex i.e. solr.directoryFactory randomisation from the several
> callers to just-once in createCollection
> These changes are refactors only and intended to *not* change the existing
> tests' behaviour.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
