[
https://issues.apache.org/jira/browse/SOLR-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086777#comment-15086777
]
Jason Gerlowski commented on SOLR-8184:
---------------------------------------
To follow up on my prior comment, it turns out that the test file Kevin
referred to above (JdbcDriverTest) does involve much less overhead (it runs in
~1sec on my machine.). Since the overheard on these tests is much lower, I
second Kevin's recommendation that we move everything we can into
JdbcDriverTest .
There are really 3 tests in question here:
testConnectionStringWithMissingZkHost, testConnectionStringJumbled, and
testConnectionStringWithWrongCollection. The first of these is already covered
by JdbcDriverTest.testNullZkConnectionString. The second doesn't have a
JdbcDriverTest analog, but could easily be moved over to JdbcDriverTest. The
third test case would be more difficult to move, as it involves checking an
error arises after connecting, creating a statement, etc. There doesn't look
like there's an easy way to port this over.
My suggestion/vote would be:
1.) Totally drop the first test (since it already has coverage in
JdbcDriverTest),
2.) Move the second test to JdbcDriverTest,
3.) Keep the third test in JdbcTest, but move it into the doTest() method.
This allows it to avoid incurring the unnecessary overheard, as Kevin mentioned
above.
Anyone have thoughts/suggestions/counterarguments? I'm happy to make these
modifications myself if others find them reasonable, but I don't want to step
on any toes. [[email protected]] pushed the first revision of this up,
so I'll hold off for a few days to see if he has any thoughts.
Otherwise (assuming people are ok with my proposed plan), I'll go ahead with
this.
> Negative tests for JDBC Connection String
> -----------------------------------------
>
> Key: SOLR-8184
> URL: https://issues.apache.org/jira/browse/SOLR-8184
> Project: Solr
> Issue Type: Test
> Environment: Trunk
> Reporter: Susheel Kumar
> Priority: Minor
> Attachments: SOLR-8184.patch, SOLR-8184.patch
>
>
> Ticket to track negative tests for JDBC connection string SOLR-7986
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
