[ 
https://issues.apache.org/jira/browse/LUCENE-6957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087770#comment-15087770
 ] 

Robert Muir commented on LUCENE-6957:
-------------------------------------

its an easy one liner:
{noformat}
--- lucene/tools/javadoc/ecj.javadocs.prefs     (revision 1723604)
+++ lucene/tools/javadoc/ecj.javadocs.prefs     (working copy)
@@ -47,7 +47,7 @@
 
org.eclipse.jdt.core.compiler.problem.missingJavadocTagsMethodTypeParameters=disabled
 org.eclipse.jdt.core.compiler.problem.missingJavadocTagsOverriding=disabled
 org.eclipse.jdt.core.compiler.problem.missingJavadocTagsVisibility=public
-org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore
+org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=error
 
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled
 org.eclipse.jdt.core.compiler.problem.missingSerialVersion=ignore
 
org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore
{noformat}

Gives 20 fails on lucene-core already:
{noformat}
 [ecj-lint] Compiling 744 source files to /tmp/ecj2121351062
 [ecj-lint] ----------
 [ecj-lint] 1. ERROR in 
/home/rmuir/workspace/trunk2/lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50CompoundReader.java
 (at line 156)
 [ecj-lint]     public void renameFile(String from, String to) {
 [ecj-lint]                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] The method renameFile(String, String) of type 
Lucene50CompoundReader should be tagged with @Override since it actually 
overrides a superclass method
 [ecj-lint] ----------
 [ecj-lint] ----------
 [ecj-lint] 2. ERROR in 
/home/rmuir/workspace/trunk2/lucene/core/src/java/org/apache/lucene/codecs/lucene60/Lucene60DimensionalWriter.java
 (at line 98)
 [ecj-lint]     public void visit(int docID, byte[] packedValue) throws 
IOException {
 [ecj-lint]                 
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 [ecj-lint] The method visit(int, byte[]) of type new 
DimensionalValues.IntersectVisitor(){} should be tagged with @Override since it 
actually overrides a superinterface method
 [ecj-lint] ----------
...
{noformat}

> NRTCachingDirectory is missing createTempOutput
> -----------------------------------------------
>
>                 Key: LUCENE-6957
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6957
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: Trunk
>
>         Attachments: LUCENE-6957.patch, LUCENE-6957.patch
>
>
> It's broken now because it simply delegates to the wrapped dir now,
> which can create an output that already exists in the ram dir cache.
> This bug only affects trunk (it's never been released).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to