[ 
https://issues.apache.org/jira/browse/LUCENE-6967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088087#comment-15088087
 ] 

Robert Muir commented on LUCENE-6967:
-------------------------------------

ECJ is actually a compiler, so we can't just exclude files because they are 
generated.

So I think we have to add the missing Overrides in the code generation?

> Fail the build on missing Override annotation
> ---------------------------------------------
>
>                 Key: LUCENE-6967
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6967
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Priority: Minor
>
> Spin-off of LUCENE-6957. Even though javac does not support it, ecj does with 
> this one-liner:
> {noformat}
> --- lucene/tools/javadoc/ecj.javadocs.prefs   (revision 1723604)
> +++ lucene/tools/javadoc/ecj.javadocs.prefs   (working copy)
> @@ -47,7 +47,7 @@
>  
> org.eclipse.jdt.core.compiler.problem.missingJavadocTagsMethodTypeParameters=disabled
>  org.eclipse.jdt.core.compiler.problem.missingJavadocTagsOverriding=disabled
>  org.eclipse.jdt.core.compiler.problem.missingJavadocTagsVisibility=public
> -org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore
> +org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=error
>  
> org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled
>  org.eclipse.jdt.core.compiler.problem.missingSerialVersion=ignore
>  
> org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to