[ 
https://issues.apache.org/jira/browse/SOLR-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094953#comment-15094953
 ] 

Gregory Chanan commented on SOLR-8415:
--------------------------------------

bq. 2) The FunctionalInterface is the right way to do this, but it would be 
nice to have in 5.x as well. I'm willing to create a separate patch that drops 
it specifically for 5.x

Sure, let's do a separate patch if that's what you prefer.

{quote}3) Naming things is hard, I hadn't considered the possible confusion 
there but now that you point it out I can't unsee it. Maybe setAcl and 
updateAcls? updateAllAcl? Is it fine to still call the ZkCli command resetacl? 
Maybe reinitacl? Original intent was to convey something with gravitas.{quote}

I think setAcl and updateAcls is good.  I get the gravitas point, but anything 
with "re" I think is going to cause more confusion because it implies some 
initial state that may or may not be true.  I'd just match the ZkCli command 
name to the SolrZkClient function name, so in this case updateAcls.  But if you 
feel really strongly for something else, let's do that.

> Provide command to switch between non/secure mode in ZK
> -------------------------------------------------------
>
>                 Key: SOLR-8415
>                 URL: https://issues.apache.org/jira/browse/SOLR-8415
>             Project: Solr
>          Issue Type: Improvement
>          Components: security, SolrCloud
>            Reporter: Mike Drob
>            Assignee: Gregory Chanan
>             Fix For: Trunk
>
>         Attachments: SOLR-8415.patch, SOLR-8415.patch, SOLR-8415.patch, 
> SOLR-8415.patch
>
>
> We have the ability to run both with and without zk acls, but we don't have a 
> great way to switch between the two modes. Most common use case, I imagine, 
> would be upgrading from an old version that did not support this to a new 
> version that does, and wanting to protect all of the existing content in ZK, 
> but it is conceivable that a user might want to remove ACLs as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to