[ 
https://issues.apache.org/jira/browse/SOLR-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Thacker updated SOLR-8534:
--------------------------------
    Attachment: SOLR-8534.patch

Updated patch.

Made some minor change

- Remove unused variable 

{code}
+    } catch (SolrException e) {
+      //expected
+      int x =10;
+    }
{code}

- Reverted wrong change in previous patches for OVERSEERSTATUS_OP which returns 
a Collections.EMPTY_MAP

{code}
     OVERSEERSTATUS_OP(OVERSEERSTATUS) {
       @Override
       Map<String, Object> call(SolrQueryRequest req, SolrQueryResponse rsp, 
CollectionsHandler h) throws Exception {
-        return new LinkedHashMap<>();
+        return Collections.EMPTY_MAP;
       }
{code}

- Removed final from the setAsyncId signature. Certain operations might need to 
throw unsupported operation


All tests pass. I'll commit this shortly

> Add generic support for Collection APIs to be async
> ---------------------------------------------------
>
>                 Key: SOLR-8534
>                 URL: https://issues.apache.org/jira/browse/SOLR-8534
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Varun Thacker
>            Assignee: Varun Thacker
>             Fix For: 5.5, Trunk
>
>         Attachments: SOLR-8534.patch, SOLR-8534.patch, SOLR-8534.patch, 
> SOLR-8534.patch
>
>
> Currently only a handful of Collection API calls support the async parameter. 
> I propose to extended support for async to most APIs.
> The Overseer has a generic support for calls to be async. So we should 
> leverage that and make all commands implemented within the 
> OverseerCollectionMessageHandler to support async



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to