[ 
https://issues.apache.org/jira/browse/SOLR-8514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108790#comment-15108790
 ] 

Kevin Risden commented on SOLR-8514:
------------------------------------

[~joel.bernstein] According to the JavaDoc for Statement (excerpts below), I 
think the isClosed() check needs to be there to comply with the interface.

>From the JavaDoc for Statement#executeQuery
{quote}
     * @exception SQLException if a database access error occurs,
     * this method is called on a closed <code>Statement</code>, the given
     *            SQL statement produces anything other than a single
     *            <code>ResultSet</code> object, the method is called on a
     * <code>PreparedStatement</code> or <code>CallableStatement</code>
{quote}

>From the JavaDoc for Statement#execute
{quote}
 * @exception SQLException if a database access error occurs,
     * this method is called on a closed <code>Statement</code>,
     * the method is called on a
     * <code>PreparedStatement</code> or <code>CallableStatement</code>
{quote}

> Implement StatementImpl.execute(String sql), StatementImpl.getResultSet(), 
> and StatementImpl.getUpdateCount()
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8514
>                 URL: https://issues.apache.org/jira/browse/SOLR-8514
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrJ
>    Affects Versions: Trunk
>            Reporter: Kevin Risden
>            Assignee: Joel Bernstein
>         Attachments: SOLR-8514.patch, SOLR-8514.patch, SOLR-8514.patch, 
> SOLR-8514.patch
>
>
> Currently only StatementImpl.executeQuery is implemented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to