[ 
https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110095#comment-15110095
 ] 

Mark Miller commented on SOLR-8451:
-----------------------------------

Okay, I'd like to come back to this and actually add an attempt to make sure we 
have always consumed the full response inputstream before closing it.

I have read, and testing shows, HttpClient appears to clean up these situations 
for us. We have fine connection reuse, even under error conditions. However, 
given Jetty was doing this for us on the server side basically, and then all of 
a sudden it was only half hearted attempting it (which broke us), I think it's 
better to put it into our client code explicitly.

Just would make me sleep better, especially considering issues like SOLR-8578 
ConcurrentUpdateSolrServer with BinaryResponseParser leaves 40-42 bytes 
unconsumed from the request response even without errors.

> We should not call method.abort in HttpSolrClient and 
> HttpSolrCall#remoteQuery should not close streams.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8451
>                 URL: https://issues.apache.org/jira/browse/SOLR-8451
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>         Attachments: SOLR-8451.patch, SOLR-8451.patch, SOLR-8451.patch, 
> SOLR-8451.patch, SOLR-8451.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to