[ 
https://issues.apache.org/jira/browse/SOLR-8554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110840#comment-15110840
 ] 

Erick Erickson commented on SOLR-8554:
--------------------------------------

As we were talking yesterday, max_at_once has never worked so removing it seems 
fine. I don't even think we need to deprecate it.

> RebalanceLeader and ForceLeader APIs should be part of 
> OverseerCollectionMessageHandler
> ---------------------------------------------------------------------------------------
>
>                 Key: SOLR-8554
>                 URL: https://issues.apache.org/jira/browse/SOLR-8554
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Varun Thacker
>         Attachments: SOLR-8554.patch
>
>
> I think RebalanceLeader and ForceLeader API calls should be part of the 
> OverseerCollectionMessageHandler.
> There are two reasons for this -
> 1. If the API is implemented within the OverseerCollectionMessageHandler the 
> Overseer provides us with concurrency guarantees i.e two calls against a 
> collection can't be executed simultaneously .
> An example, a delete shard was fired and simultaneously a force leader was 
> fired. Now say the replica which was meant to be deleted became the new 
> leader.
> 2. Less important that 1 , but if the API is implemented within the 
> OverseerCollectionMessageHandler , we can provide an async option in these 
> APIs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to