[ 
https://issues.apache.org/jira/browse/SOLR-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116328#comment-15116328
 ] 

Arcadius Ahouansou commented on SOLR-8522:
------------------------------------------

Hello again [~noble.paul]
Thank you very much for taking the time to have a look.

- I have changed the node format from {{http://host:post/context/collection}} 
... to {{host:port_context}}
- To further simplify things, I have also removed all tests related to 
SOLR-8523 . Tests will be added later to SOLR-8523


I need one clarification:

In the original {{ImplicitSnitch.java}}, we have:
{code}
Pattern hostAndPortPattern = Pattern.compile("(?:https?://)?([^:]+):(\\d+)")
{code}
Is that regex accurate given that node names do not contain any {{http}} or  
{{https}} in the format specified above?

Thank you very much

> ImplicitSnitch to support IPv4 fragment and host name  fragment tags
> --------------------------------------------------------------------
>
>                 Key: SOLR-8522
>                 URL: https://issues.apache.org/jira/browse/SOLR-8522
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>    Affects Versions: 5.4
>            Reporter: Arcadius Ahouansou
>            Assignee: Noble Paul
>            Priority: Minor
>         Attachments: SOLR-8522.patch, SOLR-8522.patch, SOLR-8522.patch
>
>
> This is a description from [~noble.paul]'s comment on SOLR-8146
> h3. IPv4 fragment tags
> Lets assume a Solr node IPv4 address is {{192.93.255.255}} .
> This is about enhancing the current {{ImplicitSnitch}}  to support IP based 
> tags like:
> - {{hostfrag_1 = 255}}
> - {{hostfrag_2 = 255}}
> - {{hostfrag_3 = 93}}
> - {{hostfrag_4 = 192}}
> Note that IPv6 support will be implemented by a separate ticket
> h3. Host name fragment tags
> Lets assume a Solr node host name {{serv1.dc1.country1.apache.org}} .
> This is about enhancing the current {{ImplicitSnitch}}  to support  tags like:
> - {{hostfrag_1 = org}}
> - {{hostfrag_2 = apache}}
> - {{hostfrag_3 = country1}}
> - {{hostfrag_4 = dc1}}
> - {{hostfrag_5 = serv1}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to