[ 
https://issues.apache.org/jira/browse/SOLR-8518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117421#comment-15117421
 ] 

Joel Bernstein commented on SOLR-8518:
--------------------------------------

I made a few slight changes and am running precommit now.

1) I moved the wrapping of the PushBackStream into the ResultSetImpl. Just felt 
this was a detail only the ResultSet needed to know.
2) Checking for null value on a column and setting the class to String. This is 
actually correct because only String fields can be null. Numerics will return 0 
if null.

> Implement ResultSetMetaDataImpl getColumnType and getColumnTypeName
> -------------------------------------------------------------------
>
>                 Key: SOLR-8518
>                 URL: https://issues.apache.org/jira/browse/SOLR-8518
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrJ
>    Affects Versions: Trunk
>            Reporter: Kevin Risden
>         Attachments: SOLR-8518.patch
>
>
> DBVisualizer uses getColumnType and getColumnTypeName to determine which 
> ResultSetImpl.get* method to use when displaying the data otherwise it falls 
> back to ResultSetImpl.getObject.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to