[
https://issues.apache.org/jira/browse/LUCENE-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-6999:
---------------------------------------
Attachment: LUCENE-6999.patch
Here's a patch, folding in [~rcmuir]'s test changes, and adding a {{finish}}
method to {{PointWriter}}, and fixing segment flushing and merging to call it,
heroically.
> Lucene60PointsWriter has a buggy close method
> ---------------------------------------------
>
> Key: LUCENE-6999
> URL: https://issues.apache.org/jira/browse/LUCENE-6999
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Michael McCandless
> Attachments: LUCENE-6999.patch, LUCENE-6999_test.patch
>
>
> This will leak a file handle on e.g. disk full or other exceptions
> {noformat}
> @Override
> public void close() throws IOException {
> if (closed == false) {
> CodecUtil.writeFooter(dataOut); // something bad happens
> dataOut.close();
> {noformat}
> I'm not a fan of these complex close methods, should we add a finish() to the
> codec api or similar?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
