[
https://issues.apache.org/jira/browse/LUCENE-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121901#comment-15121901
]
Michael McCandless commented on LUCENE-6998:
--------------------------------------------
bq. Should we worry about these?
This is git being wonderfully honest (the same reason why I love the "merge
bubbles").
On backport, git told me there were conflicts, since these files were changed
in master but don't exist in 5.x ("points" is a 6.0 only feature). So I
removed them, and left this default commit message generated by git to preserve
its honesty ....
So I don't think we need to worry ;)
> We should detect truncation for all index files
> -----------------------------------------------
>
> Key: LUCENE-6998
> URL: https://issues.apache.org/jira/browse/LUCENE-6998
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 5.5, Trunk, 6.0
>
> Attachments: LUCENE-6998.patch, LUCENE-6998.patch, LUCENE-6998.patch
>
>
> [~rcmuir] noticed that {{Lucene60PointReader}} does not detect truncation of
> its data file on reader init ... so I added a test to catch this, confirmed
> it caught the bug, and fixed the bug, and fixed a couple other things
> uncovered by the test.
> I also improved the other {{TestAllFiles*}} tests to use {{LineFileDocs}} so
> they index points, and it caught another bug in {{Lucene60PointFormat}}
> (using the same codec name in two files).
> There is more to do here, e.g. we also need a test that catches places where
> we fail to check the index header on init, which was also missing for
> {{Lucene60PointReader}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
