[
https://issues.apache.org/jira/browse/LUCENE-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131434#comment-15131434
]
Jason Gerlowski commented on LUCENE-7013:
-----------------------------------------
Hi Shai,
Have a few tweaks that might make sense for your Python script. Probably my
only substantive suggestion is that you can use Python's
heredoc/multi-line-string format for the license text. This lets you avoid
suffixing each line with "\r\n". FWIW, I don't think this has any affect on
the correctness of your script, just a stylistic thing. Shouldn't matter
either way; just wanted to mention in case you were planning on committing the
script for use down the road.
> Move license header before package declaration in all *.java files
> ------------------------------------------------------------------
>
> Key: LUCENE-7013
> URL: https://issues.apache.org/jira/browse/LUCENE-7013
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Attachments: LUCENE-7013.patch, mvcopyright.py
>
>
> In LUCENE-7012 we committed a change to the IDE templates to place the
> license header before the package declaration in new Java files.
> I wrote a simple Python script which moves the header before the package
> declaration. To be on the safe side, if a .java file does not already start
> with the license header or with {{package org.apache}}, it doesn't modify it
> and asks for manual intervention.
> It runs quite fast, so I don't mind running and committing one module at a
> time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
