[
https://issues.apache.org/jira/browse/SOLR-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131633#comment-15131633
]
ASF GitHub Bot commented on SOLR-8639:
--------------------------------------
GitHub user mbreslow opened a pull request:
https://github.com/apache/lucene-solr/pull/5
SOLR-8639 replace static SimpleDateFormat with threadsafe
jodatimeDateFormatter
Resolve issue SOLR-8639:
sinceDateParser and afterFmt are declared as static variables of type
SimpleDateFormat which is not threadsafe. This may cause data corruption and an
incorrect value to be returned by the methods that use them.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DevFactory/lucene-solr
SOLR-8639-replace-static-sdf-with-jodatime
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit b5832f0e27a399d8d9a24e1fd9a77e876cc1cbe5
Author: Marc Breslow <[email protected]>
Date: 2016-02-04T03:02:37Z
Replaced static class variables of type SimpleDateFormat with
DateTimeFormatter instances from joda-time.
The joda-time types are threadsafe which is appropriate for this usecase.
Keeping the SDF instances could
cause data corruption or incorrect values to be returned from the methods
that use them.
commit ebf7b79ece36a0fca445f99b19931c32bb04b57c
Author: Marc Breslow <[email protected]>
Date: 2016-02-04T03:05:01Z
clean up imports
----
> SimpleDateFormat static class variables found in
> org.apache.solr.handler.dataimport.MailEntityProcessor
> -------------------------------------------------------------------------------------------------------
>
> Key: SOLR-8639
> URL: https://issues.apache.org/jira/browse/SOLR-8639
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: Trunk
> Reporter: Marc Breslow
>
> sinceDateParser and afterFmt are declared as static variables of type
> SimpleDateFormat which is not threadsafe. This may cause data corruption and
> an incorrect value to be returned by the methods that use them.
> Pull request coming...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
