[
https://issues.apache.org/jira/browse/LUCENE-6835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136358#comment-15136358
]
ASF subversion and git services commented on LUCENE-6835:
---------------------------------------------------------
Commit f8bd22e58c953a5ef27fd4859c91845755ebd490 in lucene-solr's branch
refs/heads/master from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f8bd22e ]
LUCENE-6835, LUCENE-6684: move the 'suppress NSFE on windows' hack down lower,
out of IFD into FSDir; also fix IFD to remove segments files before others
> Directory.deleteFile should "own" retrying deletions on Windows
> ---------------------------------------------------------------
>
> Key: LUCENE-6835
> URL: https://issues.apache.org/jira/browse/LUCENE-6835
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Fix For: master, 6.0
>
> Attachments: LUCENE-6835.patch, LUCENE-6835.patch
>
>
> Rob's idea:
> Today, we have hairy logic in IndexFileDeleter to deal with Windows file
> systems that cannot delete still open files.
> And with LUCENE-6829, where OfflineSorter now must deal with the situation
> too ... I worked around it by fixing all tests to disable the virus checker.
> I think it makes more sense to push this "platform specific problem" lower in
> the stack, into Directory? I.e., its deleteFile method would catch the
> access denied, and then retry the deletion later. Then we could re-enable
> virus checker on all these tests, simplify IndexFileDeleter, etc.
> Maybe in the future we could further push this down, into WindowsDirectory,
> and fix FSDirectory.open to return WindowsDirectory on windows ...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
